HomePhabricator

rpc: Prevent `dumpwallet` from overwriting files

Description

rpc: Prevent dumpwallet from overwriting files

Summary:
Prevent arbitrary files from being overwritten. There have been reports
that users have overwritten wallet files this way. It may also avoid
other security issues.

Fixes #9934. Adds mention to release notes and adds a test.

Backport core's PR9937

Depends on D1165

Test Plan:

make check
./test/functional/test_runner.py wallet-dump

Reviewers: #bitcoin_abc, schancel

Reviewed By: #bitcoin_abc, schancel

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1166

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Mar 7 2017, 08:50
deadalnixCommitted on Mar 5 2018, 21:30
schancelPushed on Mar 5 2018, 22:05
Reviewer
Restricted Project
Differential Revision
D1166: rpc: Prevent `dumpwallet` from overwriting files
Parents
rSTAGING291a6ce84054: Add friendly output to dumpwallet
Branches
Unknown
Tags
Unknown

Event Timeline