HomePhabricator

Merge #13498: [wallet] Fixups from account API deprecation

Description

Merge #13498: [wallet] Fixups from account API deprecation

Summary:
df10f07db1 [wallet] Don't use accounts when checking balance in sendmany (John Newbery)
e209184101 [wallet] deprecate sendfrom RPC method. (John Newbery)

Pull request description:

A couple of fixups from the accounts API deprecation PR (#12953):

- properly deprecate `sendfrom`
- don't use accounts when calculating balance in `sendmany` (unless the `-deprecatedrpc=accounts` flag is being used)

Tree-SHA512: 1befde055067438c4c3391bbff1aaed0e6249efd708c567db3f1faad40a0f28e64f95e5bad0679ae826d24a0239e4bc8a1c392dc93e2e7502343a7f6b1d1845c

Backport of Core PR13498
https://github.com/bitcoin/bitcoin/pull/13498/files

Depends on D4519

Test Plan:

ninja check
test_runner.py

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4528

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on Jun 26 2018, 23:45
jasonbcoxCommitted on Nov 26 2019, 23:35
jasonbcoxPushed on Nov 27 2019, 00:18
Reviewer
Restricted Project
Differential Revision
D4528: Merge #13498: [wallet] Fixups from account API deprecation
Parents
rSTAGINGb03fb98a32d9: Merge #12639: Reduce cs_main lock and avoid extra lookups of mapAddressBook in…
Branches
Unknown
Tags
Unknown