Page MenuHomePhabricator

[wallet] [rpc] Remove getlabeladdress RPC
ClosedPublic

Authored by nakihito on Sat, Nov 23, 01:54.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC3e80fb1e89f0: [wallet] [rpc] Remove getlabeladdress RPC
Summary

labels are associated with addresses (rather than addresses being
associated with labels, as was the case with accounts). The
getlabeladdress does not make sense in this model, so remove it.

getaccountaddress is still supported for one release as the accounts
API is deprecated.

Backport of Core PR13060
https://github.com/bitcoin/bitcoin/pull/13060/

Depends on D4518

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Sat, Nov 23, 01:54
Owners added a reviewer: Restricted Owners Package.Sat, Nov 23, 01:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Nov 23, 01:54
deadalnix requested changes to this revision.Sat, Nov 23, 15:19
deadalnix edited the summary of this revision. (Show Details)

Backport the doc with the behavior change. These are not separable.

This revision now requires changes to proceed.Sat, Nov 23, 15:20
nakihito updated this revision to Diff 14388.Mon, Nov 25, 18:16

Updated release notes.

nakihito edited the summary of this revision. (Show Details)Mon, Nov 25, 23:55
nakihito edited the summary of this revision. (Show Details)
deadalnix accepted this revision.Tue, Nov 26, 22:38
This revision is now accepted and ready to land.Tue, Nov 26, 22:38
This revision was automatically updated to reflect the committed changes.