Page MenuHomePhabricator

Merge #13498: [wallet] Fixups from account API deprecation
ClosedPublic

Authored by jasonbcox on Sat, Nov 23, 17:28.

Details

Summary

df10f07db1 [wallet] Don't use accounts when checking balance in sendmany (John Newbery)
e209184101 [wallet] deprecate sendfrom RPC method. (John Newbery)

Pull request description:

A couple of fixups from the accounts API deprecation PR (#12953):

- properly deprecate `sendfrom`
- don't use accounts when calculating balance in `sendmany` (unless the `-deprecatedrpc=accounts` flag is being used)

Tree-SHA512: 1befde055067438c4c3391bbff1aaed0e6249efd708c567db3f1faad40a0f28e64f95e5bad0679ae826d24a0239e4bc8a1c392dc93e2e7502343a7f6b1d1845c

Backport of Core PR13498
https://github.com/bitcoin/bitcoin/pull/13498/files

Depends on D4519

Test Plan
ninja check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Sat, Nov 23, 17:28
jasonbcox planned changes to this revision.Sat, Nov 23, 17:28
jasonbcox requested review of this revision.Sat, Nov 23, 17:42
jasonbcox added inline comments.
test/functional/wallet_labels.py
119 ↗(On Diff #14355)

The missing change from the PR is due to D1799

Fabien accepted this revision.Sun, Nov 24, 09:51
This revision is now accepted and ready to land.Sun, Nov 24, 09:51