Page MenuHomePhabricator
Differential D4519

[wallet] [rpc] Remove getlabeladdress RPC
ClosedPublic
Actions

Authored by nakihito on Nov 23 2019, 01:54.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING3e80fb1e89f0: [wallet] [rpc] Remove getlabeladdress RPC
rABC3e80fb1e89f0: [wallet] [rpc] Remove getlabeladdress RPC
Summary

labels are associated with addresses (rather than addresses being
associated with labels, as was the case with accounts). The
getlabeladdress does not make sense in this model, so remove it.

getaccountaddress is still supported for one release as the accounts
API is deprecated.

Backport of Core PR13060
https://github.com/bitcoin/bitcoin/pull/13060/

Depends on D4518

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13060-1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8244
Build 14513: Default Diff Build & Tests
Build 14512: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 23 2019, 01:54
Owners added a reviewer: Restricted Owners Package.Nov 23 2019, 01:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2019, 01:54
teamcity added a comment.Nov 23 2019, 01:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 23 2019, 02:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8244: Diff 14344.Nov 23 2019, 02:04
deadalnix requested changes to this revision.Nov 23 2019, 15:19
deadalnix edited the summary of this revision. (Show Details)

Backport the doc with the behavior change. These are not separable.

This revision now requires changes to proceed.Nov 23 2019, 15:20
jasonbcox added a child revision: D4528: Merge #13498: [wallet] Fixups from account API deprecation.Nov 23 2019, 17:29
nakihito updated this revision to Diff 14388.Nov 25 2019, 18:16

Updated release notes.

teamcity added a comment.Nov 25 2019, 19:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 19:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8272: Diff 14388.Nov 25 2019, 19:19
nakihito edited the summary of this revision. (Show Details)Nov 25 2019, 23:55
nakihito edited the summary of this revision. (Show Details)
deadalnix accepted this revision.Nov 26 2019, 22:38
This revision is now accepted and ready to land.Nov 26 2019, 22:38
Closed by commit rABC3e80fb1e89f0: [wallet] [rpc] Remove getlabeladdress RPC (authored by John Newbery <john@johnnewbery.com>, committed by nakihito). · Explain WhyNov 26 2019, 23:15
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC3e80fb1e89f0: [wallet] [rpc] Remove getlabeladdress RPC.
Fabien mentioned this in D4558: Fix copy in loop.Nov 27 2019, 10:24
Fabien mentioned this in rABC1bb6a8c1379a: Fix copy in loop.Nov 27 2019, 13:12
nakihito added a commit: rSTAGING3e80fb1e89f0: [wallet] [rpc] Remove getlabeladdress RPC.Apr 7 2020, 21:52
Fabien mentioned this in rSTAGING1bb6a8c1379a: Fix copy in loop.Apr 7 2020, 21:53

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
rpc/
1 line
wallet/
101 lines
test/
functional/
5 lines
89 lines

Diff 14344

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/rpc_deprecated.py

Loading...
View Options

test/functional/wallet_labels.py

Loading...