Page MenuHomePhabricator

[wallet] [rpc] Remove getlabeladdress RPC
ClosedPublic

Authored by nakihito on Nov 23 2019, 01:54.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING3e80fb1e89f0: [wallet] [rpc] Remove getlabeladdress RPC
rABC3e80fb1e89f0: [wallet] [rpc] Remove getlabeladdress RPC
Summary

labels are associated with addresses (rather than addresses being
associated with labels, as was the case with accounts). The
getlabeladdress does not make sense in this model, so remove it.

getaccountaddress is still supported for one release as the accounts
API is deprecated.

Backport of Core PR13060
https://github.com/bitcoin/bitcoin/pull/13060/

Depends on D4518

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13060-1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8244
Build 14513: Default Diff Build & Tests
Build 14512: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Nov 23 2019, 01:54
deadalnix requested changes to this revision.Nov 23 2019, 15:19
deadalnix edited the summary of this revision. (Show Details)

Backport the doc with the behavior change. These are not separable.

This revision now requires changes to proceed.Nov 23 2019, 15:20
nakihito edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Nov 26 2019, 22:38