HomePhabricator

Bugfix: Include <memory> for std::unique_ptr

Description

Bugfix: Include <memory> for std::unique_ptr

Summary:

Not sure why all these includes were missing, but it's breaking builds
for some users:

https://bugs.gentoo.org/show_bug.cgi?id=652142

(Added to all files with a reference to std::unique_ptr)

Backport of core PR12859:
https://github.com/bitcoin/bitcoin/pull/12859/files

This has been heavily adapted to our codebase.
I grepped all the units (.h and .cpp) including memory, the ones using
std_unique_ptr and used the diff to track down the needed inclusions.

Test Plan:

ninja check bench-bitcoin

Run the gitian builds.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4611

Details

Provenance
Luke Dashjr <luke-jr+git@utopios.org>Authored on Apr 2 2018, 18:31
FabienCommitted on Dec 3 2019, 10:06
nakihitoPushed on Dec 3 2019, 19:11
Reviewer
Restricted Project
Differential Revision
D4611: Bugfix: Include <memory> for std::unique_ptr
Parents
rSTAGING22a1d33378fb: fix undefined behaviour in seeder (select() aliasing)
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/14603, tag: phabricator/base/14601, tag: phabricator/base/14594