Page MenuHomePhabricator

Bugfix: Include <memory> for std::unique_ptr
ClosedPublic

Authored by Fabien on Mon, Dec 2, 12:59.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe2dc6148fb29: Bugfix: Include <memory> for std::unique_ptr
Summary
Not sure why all these includes were missing, but it's breaking builds
for some users:

https://bugs.gentoo.org/show_bug.cgi?id=652142

(Added to all files with a reference to std::unique_ptr)

Backport of core PR12859:
https://github.com/bitcoin/bitcoin/pull/12859/files

This has been heavily adapted to our codebase.
I grepped all the units (.h and .cpp) including memory, the ones using
std_unique_ptr and used the diff to track down the needed inclusions.

Test Plan
ninja check bench-bitcoin

Run the gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Dec 2, 12:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 2, 12:59
deadalnix accepted this revision.Mon, Dec 2, 14:27

Verify cross compile build to make sure you did not fibared something, but LGTM

This revision is now accepted and ready to land.Mon, Dec 2, 14:27
Fabien edited the test plan for this revision. (Show Details)Mon, Dec 2, 15:04
Fabien edited the summary of this revision. (Show Details)Tue, Dec 3, 08:09
Fabien removed a parent revision: D4588: [tests] Add libFuzzer support..
Fabien updated this revision to Diff 14591.Tue, Dec 3, 08:10

Rebase.
Break the dependency to D4588, which will temporarly add a useless include for the sake of avoinding a rebase hell.

This revision was automatically updated to reflect the committed changes.