Page MenuHomePhabricator

Bugfix: Include <memory> for std::unique_ptr
ClosedPublic

Authored by Fabien on Dec 2 2019, 12:59.

Details

Summary
Not sure why all these includes were missing, but it's breaking builds
for some users:

https://bugs.gentoo.org/show_bug.cgi?id=652142

(Added to all files with a reference to std::unique_ptr)

Backport of core PR12859:
https://github.com/bitcoin/bitcoin/pull/12859/files

This has been heavily adapted to our codebase.
I grepped all the units (.h and .cpp) including memory, the ones using
std_unique_ptr and used the diff to track down the needed inclusions.

Test Plan
ninja check bench-bitcoin

Run the gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12859
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8386
Build 14790: Default Diff Build & Tests
Build 14789: arc lint + arc unit

Event Timeline

Verify cross compile build to make sure you did not fibared something, but LGTM

This revision is now accepted and ready to land.Dec 2 2019, 14:27

Rebase.
Break the dependency to D4588, which will temporarly add a useless include for the sake of avoinding a rebase hell.