Page MenuHomePhabricator
Differential D10007

rpc: Add CRPCCommand constructor which takes RPCHelpMan
ClosedPublic
Actions

Authored by PiRK on Sep 1 2021, 11:50.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCb568655c01cc: rpc: Add CRPCCommand constructor which takes RPCHelpMan
Summary

This allows the constructor to ask the rpc manager for the name of the
rpc method or the rpc argument names instead of having it manually
passed in.

Note: added underscores to some constructors' arguments to prevent shadowing fields, like previously done in D5906

This is a backport of core#19386 [2/5]
https://github.com/bitcoin/bitcoin/pull/19386/commits/faaeb2b0b347b40ce456a951eec5e820587e5b02

Depends on D10006

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 1 2021, 11:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2021, 11:51
PiRK requested review of this revision.Sep 1 2021, 11:51
teamcity edited the summary of this revision. (Show Details)Sep 1 2021, 11:51
PiRK edited the summary of this revision. (Show Details)Sep 1 2021, 11:51
PiRK added a parent revision: D10006: rpc: Check that left section is not multiline.
PiRK added a child revision: D10008: rpc: Assert that passed arg names are equal to hardcoded ones.Sep 1 2021, 11:52
Harbormaster completed remote builds in B16507: Diff 29720.Sep 1 2021, 12:09
majcosta accepted this revision.Sep 1 2021, 12:18
This revision is now accepted and ready to land.Sep 1 2021, 12:18
PiRK planned changes to this revision.Sep 1 2021, 13:57
PiRK requested review of this revision.Sep 9 2021, 08:32
This revision is now accepted and ready to land.Sep 9 2021, 08:32
Closed by commit rABCb568655c01cc: rpc: Add CRPCCommand constructor which takes RPCHelpMan (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhySep 10 2021, 06:58
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb568655c01cc: rpc: Add CRPCCommand constructor which takes RPCHelpMan.
PiRK mentioned this in D10149: Make all CRPCCommand actors take a const Config &.Sep 17 2021, 15:07
PiRK mentioned this in rABC634fcc0ea184: Make all CRPCCommand actors take a const Config &.Sep 19 2021, 07:51

Revision Contents
Changeset List

PathSize
src/
rpc/
16 lines
14 lines
21 lines

Diff 29885

View Options

src/rpc/server.h

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...