Page MenuHomePhabricator

rpc: Add CRPCCommand constructor which takes RPCHelpMan
ClosedPublic

Authored by PiRK on Sep 1 2021, 11:50.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCb568655c01cc: rpc: Add CRPCCommand constructor which takes RPCHelpMan
Summary

This allows the constructor to ask the rpc manager for the name of the
rpc method or the rpc argument names instead of having it manually
passed in.

Note: added underscores to some constructors' arguments to prevent shadowing fields, like previously done in D5906

This is a backport of core#19386 [2/5]
https://github.com/bitcoin/bitcoin/pull/19386/commits/faaeb2b0b347b40ce456a951eec5e820587e5b02

Depends on D10006

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Sep 1 2021, 11:51
This revision is now accepted and ready to land.Sep 1 2021, 12:18
PiRK planned changes to this revision.Sep 1 2021, 13:57
PiRK requested review of this revision.Sep 9 2021, 08:32
This revision is now accepted and ready to land.Sep 9 2021, 08:32