Page MenuHomePhabricator

[backport#10973] Remove use of CRPCTable::appendCommand in wallet code
ClosedPublic

Authored by majcosta on Apr 30 2020, 12:38.

Details

Summary

4e4d9e9f85eaf9c3bec48559bd4cad3e8a9333ca This commit does not change behavior. (Russell Yanofsky)


Depends on D5871

This is a partial backport of Core PR10973

Test Plan
export CC=clang CXX=clang++
cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug -DENABLE_SANITIZERS=undefined
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Snippet of first build failure:

[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Counting objects:  97% (38/39)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Counting objects: 100% (39/39)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Counting objects: 100% (39/39), done.        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:   5% (1/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  10% (2/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  15% (3/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  20% (4/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  25% (5/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  30% (6/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  35% (7/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  40% (8/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  45% (9/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  50% (10/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  55% (11/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  60% (12/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  65% (13/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  70% (14/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  75% (15/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  80% (16/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  85% (17/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  90% (18/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects:  95% (19/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects: 100% (20/20)        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Compressing objects: 100% (20/20), done.        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] remote: Total 20 (delta 19), reused 0 (delta 0), pack-reused 0        
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290]  * [new tag]             phabricator/diff/19290 -> phabricator/diff/19290
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290]  * [new tag]             phabricator/base/19289 -> phabricator/base/19289
[12:38:26]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19290:refs/tags/phabricator/diff/19290]  * [new tag]             phabricator/base/19290 -> phabricator/base/19290
[12:38:26] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s eea63bce505feecd3c5bcfc2eed06205831275f1 --
[12:38:26] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[12:38:26] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[12:38:26] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[12:38:26] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[12:38:26] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[12:38:26] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[12:38:26] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[12:38:26] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[12:38:26] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/19290
[12:38:26] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s eea63bce505feecd3c5bcfc2eed06205831275f1 --
[12:38:26] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/19290
[12:38:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/19290
[12:38:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[12:38:27] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[12:38:27] : Build preparation done
[12:38:27]E: Step 1/2: Command Line (11m:53s)
[12:38:27] :	 [Step 1/2] Ant JUnit report watcher
[12:38:27] :		 [Ant JUnit report watcher] Watching paths:
[12:38:27] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[12:38:27] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[12:38:27] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script1074609354966546838
[12:38:27] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[12:38:27] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[12:38:27] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[12:38:27] :	 [Step 1/2] Building base image for: eea63bce5...
[12:38:27] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[12:38:27] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[12:38:27] :	 [Step 1/2] Tag name: abc-base-image-eea63bce5
[12:50:19]W:	 [Step 1/2] Process exited with code 1
[12:50:20]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

corrected self-inflicted bug and added underscores to ContextFreeRPCCommand's constructors' arguments to prevent shadowing fields

deadalnix requested changes to this revision.Apr 30 2020, 21:57
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/interfaces/chain.h
253 ↗(On Diff #19311)

Why context free?

src/wallet/rpcdump.h
8 ↗(On Diff #19311)

Use forward declarations like n the original PR.

This revision now requires changes to proceed.Apr 30 2020, 21:57

removed header include in favor of forward declaration

This revision is now accepted and ready to land.May 1 2020, 12:15