Page MenuHomePhabricator
Differential D5851

[backport#15288] Remove use of g_connman / PushInventory in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 27 2020, 14:02.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2e55f14c2d13: [backport#15288] Remove use of g_connman / PushInventory in wallet code
rABC2e55f14c2d13: [backport#15288] Remove use of g_connman / PushInventory in wallet code
Summary

6d6bcc77c058fbcfd39c7e3050bbe82fc89024cf This commit does not change behavior. (Russell Yanofsky)

Depends on D5840

This is a partial backport of Core PR15288

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 27 2020, 14:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 27 2020, 14:02
teamcity edited the summary of this revision. (Show Details)Apr 27 2020, 14:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 27 2020, 14:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 27 2020, 14:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10424: Diff 19155.Apr 27 2020, 14:14
majcosta added a child revision: D5854: [backport#15288] Remove uses of GetAdjustedTime in wallet code.Apr 27 2020, 15:11
deadalnix accepted this revision.Apr 27 2020, 16:16
This revision is now accepted and ready to land.Apr 27 2020, 16:16
Closed by commit rABC2e55f14c2d13: [backport#15288] Remove use of g_connman / PushInventory in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 27 2020, 17:25
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC2e55f14c2d13: [backport#15288] Remove use of g_connman / PushInventory in wallet code.
majcosta added a commit: rSTAGING2e55f14c2d13: [backport#15288] Remove use of g_connman / PushInventory in wallet code.May 5 2020, 19:09

Revision Contents
Changeset List

PathSize
src/
interfaces/
3 lines
6 lines
2 lines
wallet/
8 lines
test/
3 lines
7 lines
21 lines

Diff 19164

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...