Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING39c9afd531ad: [backport#10973] Remove use CValidationInterface in wallet code
rABC39c9afd531ad: [backport#10973] Remove use CValidationInterface in wallet code
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF ninja check-all cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug ninja check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
src/wallet/wallet.cpp | ||
---|---|---|
23 ↗ | (On Diff #19195) | I don't think this is needed. If it is, it is in the header, because you need to know about BlockHash to know the layout of the class due to m_last_block_processed. |
src/wallet/wallet.cpp | ||
---|---|---|
2294 ↗ | (On Diff #19200) | This should return a vector of TxId or a TxHash. Out of the scope of this backport, but you might want to consider this. |