Page MenuHomePhabricator

[backport#10973] Remove use CValidationInterface in wallet code
ClosedPublic

Authored by majcosta on Apr 28 2020, 10:38.

Details

Summary

91868e6288abf9d133620b585bc6de793a11e0e3 This commit does not change behavior. (Russell Yanofski)


Depends on D5870

This ia a partial backport of Core PR10973

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10448
Build 18716: Default Diff Build & Tests
Build 18715: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Apr 28 2020, 14:06
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/wallet.cpp
23

I don't think this is needed. If it is, it is in the header, because you need to know about BlockHash to know the layout of the class due to m_last_block_processed.

This revision now requires changes to proceed.Apr 28 2020, 14:06

removed unnecessary include header

deadalnix added inline comments.
src/wallet/wallet.cpp
2294 ↗(On Diff #19200)

This should return a vector of TxId or a TxHash. Out of the scope of this backport, but you might want to consider this.

This revision is now accepted and ready to land.Apr 28 2020, 16:10