Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING39c9afd531ad: [backport#10973] Remove use CValidationInterface in wallet code
rABC39c9afd531ad: [backport#10973] Remove use CValidationInterface in wallet code

Summary

91868e6288abf9d133620b585bc6de793a11e0e3 This commit does not change behavior. (Russell Yanofski)

Depends on D5870

This ia a partial backport of Core PR10973

Test Plan

cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15288

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10451
Build 18722: Default Diff Build & Tests
Build 18721: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 28 2020, 10:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2020, 10:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10448: Diff 19195.Apr 28 2020, 10:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

deadalnix requested changes to this revision.Apr 28 2020, 14:06

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/wallet/wallet.cpp
23 ↗	(On Diff #19195)	I don't think this is needed. If it is, it is in the header, because you need to know about `BlockHash` to know the layout of the class due to `m_last_block_processed`.