Page MenuHomePhabricator
Differential D5927

[backport#10973] Remove use of CCoinsViewMemPool::GetCoin in wallet code
ClosedPublic
Actions

Authored by majcosta on May 1 2020, 15:38.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa6069ab2ada2: [backport#10973] Remove use of CCoinsViewMemPool::GetCoin in wallet code
rABCa6069ab2ada2: [backport#10973] Remove use of CCoinsViewMemPool::GetCoin in wallet code
Summary

b1b2b238928e7be044ad62cf1b222464907ece2c This commit does not change behavior. (Russell Yanofsky)

Depends on D5906

This is a partial backport of Core PR10973

Test Plan
cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 1 2020, 15:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2020, 15:38
teamcity edited the summary of this revision. (Show Details)May 1 2020, 15:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 1 2020, 15:38

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 1 2020, 15:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10540: Diff 19346.May 1 2020, 15:48
deadalnix accepted this revision.May 1 2020, 22:15
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/rpc/rawtransaction.cpp
953 ↗(On Diff #19346)

Move comment on its own line.

This revision is now accepted and ready to land.May 1 2020, 22:15
Closed by commit rABCa6069ab2ada2: [backport#10973] Remove use of CCoinsViewMemPool::GetCoin in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyMay 2 2020, 12:50
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCa6069ab2ada2: [backport#10973] Remove use of CCoinsViewMemPool::GetCoin in wallet code.
majcosta added a child revision: D5943: [backport#10973] Remove remaining wallet accesses to node globals.May 3 2020, 09:14
majcosta added a commit: rSTAGINGa6069ab2ada2: [backport#10973] Remove use of CCoinsViewMemPool::GetCoin in wallet code.May 5 2020, 19:16

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
interfaces/
6 lines
4 lines
node/
22 lines
22 lines
rpc/
50 lines

Diff 19366

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/node/coin.h

Loading...
View Options

src/node/coin.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...