Page MenuHomePhabricator

[backport#15288] Remove use of IsRBFOptIn in wallet code
ClosedPublic

Authored by majcosta on Apr 23 2020, 20:07.

Details

Summary

bdc6628683197945326cbdfea3f53ec0b7d1949f This commit does not change behavior. (Russell Yanofsky)


Depends on D5816

This is a partial backport of Core PR15288, mostly RBF related which I left out, except for one header that looks like will be needed in the next commits

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox requested changes to this revision.Apr 23 2020, 21:12
jasonbcox added a subscriber: jasonbcox.

Why add an include if it's not needed?

This revision now requires changes to proceed.Apr 23 2020, 21:12

It would be needed if not for RBF code I did not include, and the next commit D5820 needs it. I'm trying to keep our history as close to Core as possible.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 24 2020, 14:57
This revision was automatically updated to reflect the committed changes.