Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGa131d6f94890: [backport#15288] Remove use of IsRBFOptIn in wallet code
rABCa131d6f94890: [backport#15288] Remove use of IsRBFOptIn in wallet code

Summary

bdc6628683197945326cbdfea3f53ec0b7d1949f This commit does not change behavior. (Russell Yanofsky)

Depends on D5816

This is a partial backport of Core PR15288, mostly RBF related which I left out, except for one header that looks like will be needed in the next commits

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15288

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10370
Build 18561: Default Diff Build & Tests
Build 18560: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 23 2020, 20:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2020, 20:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta edited the summary of this revision. (Show Details)Apr 23 2020, 20:08

majcosta added a parent revision: D5816: [backport#15288] Remove uses of CheckFinalTx in wallet code.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10370: Diff 19068.Apr 23 2020, 20:17

majcosta added a child revision: D5820: [backport#15288] Remove use of GetCountWithDescendants in wallet code.Apr 23 2020, 21:06

Why add an include if it's not needed?

This revision now requires changes to proceed.Apr 23 2020, 21:12

It would be needed if not for RBF code I did not include, and the next commit D5820 needs it. I'm trying to keep our history as close to Core as possible.