Paths

Table of Contentst

Differential D10048

Introduce DummyDatabase and use it in the tests
ClosedPublic
Actions

Authored by PiRK on Sep 6 2021, 14:27.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC636082e6d6ca: Introduce DummyDatabase and use it in the tests

Summary

Note: the #include <util/memory.h> is unnecessary because we use
std::make_unique rather than MakeUnique.

This is a backport of core#19102 [1/3]
https://github.com/bitcoin/bitcoin/pull/19102/commits/0103d6434ea9d155259b40575008239a3762d6f7

Depends on D10038

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16560
Build 32975: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 32974: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 6 2021, 14:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2021, 14:27

PiRK requested review of this revision.Sep 6 2021, 14:27

teamcity edited the summary of this revision. (Show Details)Sep 6 2021, 14:27

PiRK added a child revision: D10049: Remove BDB dummy databases.Sep 6 2021, 14:29

undo layout change that was not part of the PR

Harbormaster completed remote builds in B16560: Diff 29799.Sep 6 2021, 14:44

Harbormaster completed remote builds in B16563: Diff 29802.Sep 6 2021, 14:55

majcosta accepted this revision.Sep 6 2021, 15:16

This revision is now accepted and ready to land.Sep 6 2021, 15:16

Closed by commit rABC636082e6d6ca: Introduce DummyDatabase and use it in the tests (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhySep 6 2021, 16:05

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC636082e6d6ca: Introduce DummyDatabase and use it in the tests.

Revision Contents
Changeset List

Path

Size

src/

wallet/

db.h

54 lines

walletdb.cpp

2 lines

Diff 29799

View Options

src/wallet/db.h