refactor: Use explicit function type instead of template
ClosedPublic
Actions

Authored by PiRK on Sep 21 2021, 12:10.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf417c6b56780: refactor: Use explicit function type instead of template

Summary

PR description:

This PR replaces LockAssertion with AssertLockHeld, and removes LockAssertion.

This PR is compared with alternatives in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/AssertLockHeld-PRs

This is a backport of core#19979 [1/3]
https://github.com/bitcoin/bitcoin/pull/19979/commits/73f71e19965e07534eb47701f2b23c9ed59ef475

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 21 2021, 12:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2021, 12:10

PiRK requested review of this revision.Sep 21 2021, 12:10

teamcity edited the summary of this revision. (Show Details)Sep 21 2021, 12:11

PiRK added a child revision: D10172: Replace LockAssertion with a proper thread safety annotations.Sep 21 2021, 12:12

PiRK mentioned this in D10161: Use LockAssertion utility class instead of AssertLockHeld().Sep 21 2021, 12:15

Harbormaster completed remote builds in B16738: Diff 30092.Sep 21 2021, 12:23

Fabien accepted this revision.Sep 22 2021, 07:13

This revision is now accepted and ready to land.Sep 22 2021, 07:13

Closed by commit rABCf417c6b56780: refactor: Use explicit function type instead of template (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 22 2021, 08:05

This revision was automatically updated to reflect the committed changes.

PiRK mentioned this in rABC8ea2e27baa24: Use LockAssertion utility class instead of AssertLockHeld().

PiRK added a commit: rABCf417c6b56780: refactor: Use explicit function type instead of template.

Revision Contents
Changeset List

Path

Size

src/

net.h

5 lines

Diff 30107

View Options

refactor: Use explicit function type instead of templateClosedPublicActions