Page MenuHomePhabricator
Differential D10172

Replace LockAssertion with a proper thread safety annotations
ClosedPublic
Actions

Authored by PiRK on Sep 21 2021, 12:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa43673237b4f: Replace LockAssertion with a proper thread safety annotations
Summary

This is a backport of core#19979 [2/3]
https://github.com/bitcoin/bitcoin/pull/19979/commits/ab2a44297fd0796bf5797ae2a477e8e56d9c3c12

This partially revert D10161
Depends on D10171

Test Plan

With TSAN:
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 21 2021, 12:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2021, 12:12
PiRK requested review of this revision.Sep 21 2021, 12:12
teamcity edited the summary of this revision. (Show Details)Sep 21 2021, 12:13
PiRK mentioned this in D10161: Use LockAssertion utility class instead of AssertLockHeld().Sep 21 2021, 12:15
PiRK updated this revision to Diff 30095.Sep 21 2021, 12:16
PiRK added a child revision: D10173: Remove unused LockAssertion struct.

remove accidental blank line

PiRK added a comment.Sep 21 2021, 12:22

@bot build-tsan

teamcity awarded a token.Sep 21 2021, 12:23
• joeljporter retitled this revision from Replace LockAssertion with a proper thread safety annotations to Content Marketing Best Practices for 2021 .Sep 21 2021, 12:27
• joeljporter edited the summary of this revision. (Show Details)
• joeljporter edited the test plan for this revision. (Show Details)
• joeljporter edited the summary of this revision. (Show Details)
• joeljporter edited the test plan for this revision. (Show Details)
• joeljporter edited the summary of this revision. (Show Details)Sep 21 2021, 12:30
• joeljporter edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B16739: Diff 30093.Sep 21 2021, 12:32
Harbormaster completed remote builds in B16741: Diff 30095.Sep 21 2021, 12:43
PiRK retitled this revision from Content Marketing Best Practices for 2021 to Replace LockAssertion with a proper thread safety annotations.Sep 21 2021, 14:45
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)
Fabien added a subscriber: Fabien.Sep 22 2021, 07:23
Fabien added inline comments.
src/net_processing.cpp
1694 ↗(On Diff #30095)

Why is that causing an indentation change ? I think it should not

Fabien accepted this revision.Sep 22 2021, 07:27

Apparently a linter issue

This revision is now accepted and ready to land.Sep 22 2021, 07:27
PiRK mentioned this in rABC8ea2e27baa24: Use LockAssertion utility class instead of AssertLockHeld().Sep 22 2021, 08:05
Closed by commit rABCa43673237b4f: Replace LockAssertion with a proper thread safety annotations (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 22 2021, 08:08
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa43673237b4f: Replace LockAssertion with a proper thread safety annotations.
Unknown Object (User) added a subscriber: Unknown Object (User).Jul 21 2022, 04:43
This comment was removed by Mengerian.
Mengerian added a subscriber: Mengerian.Jul 21 2022, 14:24
Unknown Object (User) added a subscriber: Unknown Object (User).Mar 12 2024, 09:10
This comment was removed by Fabien.

Revision Contents
Changeset List

PathSize
src/
107 lines

Diff 30108

View Options

src/net_processing.cpp

Loading...