Page MenuHomePhabricator
Differential D10161

Use LockAssertion utility class instead of AssertLockHeld()
ClosedPublic
Actions

Authored by PiRK on Sep 20 2021, 10:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8ea2e27baa24: Use LockAssertion utility class instead of AssertLockHeld()
Summary

This change prepares for upcoming commit "Do not hide compile-time
thread safety warnings" by replacing AssertLockHeld() with
LockAssertion() where needed.

This is a backport of core#19668 [1/5]
https://github.com/bitcoin/bitcoin/pull/19668/commits/af9ea55a72c94678b343f5dd98dc78f3a3ac58cb

Backport notse:

  • We do not have a lock in RelayTransaction because we did not backport core#18044 (commit ac88e2eb619821ad7ae1d45d4b40be69051d3999)
  • This change is partially reverted in D10172 after D10171 makes it possible to annotate the lambda functions with EXCLUSIVE_LOCKS_REQUIRED
Test Plan

With TSAN:
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 20 2021, 10:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2021, 10:24
PiRK requested review of this revision.Sep 20 2021, 10:24
teamcity edited the summary of this revision. (Show Details)Sep 20 2021, 10:24
PiRK added a child revision: D10162: Add missed thread safety annotations.Sep 20 2021, 10:25
PiRK edited the summary of this revision. (Show Details)Sep 20 2021, 10:25
Harbormaster completed remote builds in B16720: Diff 30071.Sep 20 2021, 10:35
PiRK added a comment.Sep 20 2021, 10:40

@bot build-clang

teamcity awarded a token.Sep 20 2021, 10:41
PiRK added a reverting change: D10172: Replace LockAssertion with a proper thread safety annotations.Sep 21 2021, 12:12
PiRK edited the summary of this revision. (Show Details)Sep 21 2021, 12:15
Fabien accepted this revision.Sep 22 2021, 07:00
This revision is now accepted and ready to land.Sep 22 2021, 07:00
Closed by commit rABC8ea2e27baa24: Use LockAssertion utility class instead of AssertLockHeld() (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 22 2021, 08:05
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC8ea2e27baa24: Use LockAssertion utility class instead of AssertLockHeld().
PiRK added a reverting change: rABCa43673237b4f: Replace LockAssertion with a proper thread safety annotations.Sep 22 2021, 08:07

Revision Contents
Changeset List

PathSize
src/
9 lines

Diff 30103

View Options

src/net_processing.cpp

Loading...