Page MenuHomePhabricator

[avalanche] Accept conflicting proofs from p2p
AbandonedPublic

Authored by Fabien on Sep 24 2021, 13:35.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Summary

The current behavior is to ban the peer sending a conflicting proof. Since we don't know if the proof is valid or not until the conflict is solved, this is not desirable.

Ref T1854.

Depends on D10027.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_proof_voting

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_dont_ban_conflicting_proof
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16827
Build 33497: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 33496: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Sep 24 2021, 13:35
This revision is now accepted and ready to land.Sep 27 2021, 09:05
Fabien planned changes to this revision.Oct 1 2021, 19:18

Waiting for the processor features to be complete before an ultimate rebase