Details

src/avalanche/proofcomparator.h
28 ↗	(On Diff #30225)	This calls for a ternary.
src/avalanche/test/proof_tests.cpp
655 ↗	(On Diff #30225)	Put it in its own test, no? That is this much less to recompile at once and it can run in parallel. If the header is different, then the test might as well be.

This revision now requires changes to proceed.Sep 30 2021, 15:43

Address feedback.
Note to reviewers: the test needs a TestingSetup fixture in order to initialize the coin db required when calling buildRandomProof().

Fix copyright year

Harbormaster completed remote builds in B16843: Diff 30250.Sep 30 2021, 19:47

Harbormaster completed remote builds in B16844: Diff 30251.Sep 30 2021, 19:50

Rebase

Harbormaster completed remote builds in B16854: Diff 30266.Oct 1 2021, 12:17

deadalnix accepted this revision.Oct 1 2021, 13:34

This revision is now accepted and ready to land.Oct 1 2021, 13:34

Closed by commit rABC97c8ab66348b: [avalanche] Add a comparator for proof shared pointers (authored by abc-bot, committed by Fabien). · Explain WhyOct 1 2021, 19:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC97c8ab66348b: [avalanche] Add a comparator for proof shared pointers.