Page MenuHomePhabricator
Differential D1023

Add support to build tests with cmake
ClosedPublic
Actions

Authored by deadalnix on Jan 23 2018, 16:04.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING3245df08822a: Add support to build tests with cmake
rABC3245df08822a: Add support to build tests with cmake
Summary

This build the test_bitcoin binary. The tests that require code generation are disabled for now.

Test Plan
ninja
./src/test/test_bitcoin

Check that tests are passing.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmaketest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1740
Build 1740: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 23 2018, 16:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2018, 16:04
deadalnix added a parent revision: D1022: Move urlDecode to where it is used.Jan 23 2018, 16:04
teamcity added a subscriber: teamcity.Jan 23 2018, 16:05

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix updated this revision to Diff 2702.Jan 23 2018, 16:14

Add FIXME. We assume boost needs dynamic linking but do nto check.

Harbormaster completed remote builds in B1741: Diff 2702.Jan 23 2018, 16:14
teamcity added a comment.Jan 23 2018, 16:16

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 23 2018, 16:24

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

teamcity added a comment.Jan 23 2018, 16:37

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

deadalnix added a child revision: D1029: [cmake] Add support for wallet tests.Jan 23 2018, 21:48
jasonbcox accepted this revision.Jan 23 2018, 22:00
jasonbcox added a subscriber: jasonbcox.

LGTM although you may want to add a comment in the code itself for why those tests are commented out. If you fix that in a timely fashion, adding the comment likely isn't necessary.

This revision is now accepted and ready to land.Jan 23 2018, 22:00
Closed by commit rABC3245df08822a: Add support to build tests with cmake (authored by deadalnix). · Explain WhyJan 24 2018, 00:37
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
27 lines
test/
80 lines

Diff 2701

View Options

src/CMakeLists.txt

Loading...
View Options

src/test/CMakeLists.txt

Loading...