Page MenuHomePhabricator

Add support to build tests with cmake
ClosedPublic

Authored by deadalnix on Jan 23 2018, 16:04.

Details

Summary

This build the test_bitcoin binary. The tests that require code generation are disabled for now.

Test Plan
ninja
./src/test/test_bitcoin

Check that tests are passing.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmaketest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1741
Build 1741: arc lint + arc unit

Event Timeline

Add FIXME. We assume boost needs dynamic linking but do nto check.

jasonbcox added a subscriber: jasonbcox.

LGTM although you may want to add a comment in the code itself for why those tests are commented out. If you fix that in a timely fashion, adding the comment likely isn't necessary.

This revision is now accepted and ready to land.Jan 23 2018, 22:00
This revision was automatically updated to reflect the committed changes.