Page MenuHomePhabricator
Differential D1024

Fix misleading "Method not found" multiwallet errors
ClosedPublic
Actions

Authored by matiu on Jan 23 2018, 16:37.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Maniphest Tasks
T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors
Commits
rSTAGINGe4f59d0d5393: Fix misleading "Method not found" multiwallet errors
rABCe4f59d0d5393: Fix misleading "Method not found" multiwallet errors
Summary

Raise RPC_WALLET_NOT_SPECIFIED instead of RPC_METHOD_NOT_FOUND when a required
wallet filename was not specified in an RPC call.

Also raise more specific RPC_WALLET_NOT_FOUND error instead of
RPC_INVALID_PARAMETER in case an invalid wallet was specified, for consistency.

Change wallet method disabled error text

Not strictly backwards compatible because the error is not new in this release.

Fixes T185

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

matiu created this revision.Jan 23 2018, 16:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2018, 16:37
Harbormaster completed remote builds in B1742: Diff 2703.Jan 23 2018, 16:37
teamcity added a subscriber: teamcity.Jan 23 2018, 16:37

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 23 2018, 16:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

deadalnix requested changes to this revision.Jan 23 2018, 21:45
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
60 ↗(On Diff #2703)

Please keep the braces.

This revision now requires changes to proceed.Jan 23 2018, 21:45
matiu updated this revision to Diff 2718.Jan 23 2018, 21:53

keep braces

teamcity added a comment.Jan 23 2018, 23:11

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix added a comment.Jan 23 2018, 23:28

You only submited the topmost patch. You need to squash everything, or use git commit --am

deadalnix requested changes to this revision.Jan 23 2018, 23:28
This revision now requires changes to proceed.Jan 23 2018, 23:28
teamcity added a comment.Jan 23 2018, 23:30

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

matiu updated this revision to Diff 2721.Jan 23 2018, 23:48

fix commit

teamcity added a comment.Jan 23 2018, 23:49

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

matiu added a comment.Jan 23 2018, 23:52

thanks, sorry about it.

teamcity added a comment.Jan 24 2018, 00:07

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

deadalnix accepted this revision.Jan 24 2018, 00:44
This revision is now accepted and ready to land.Jan 24 2018, 00:44
Closed by commit rABCe4f59d0d5393: Fix misleading "Method not found" multiwallet errors (authored by Russell Yanofsky <russ@yanofsky.org>, committed by matiu). · Explain WhyJan 24 2018, 01:03
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
7 lines
rpc/
4 lines
wallet/
17 lines
test/
functional/
6 lines

Diff 2728

View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/rpc/protocol.h

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/multiwallet.py

Loading...