Page MenuHomePhabricator

Fix misleading "Method not found" multiwallet errors
ClosedPublic

Authored by matiu on Jan 23 2018, 16:37.

Details

Summary

Raise RPC_WALLET_NOT_SPECIFIED instead of RPC_METHOD_NOT_FOUND when a required
wallet filename was not specified in an RPC call.

Also raise more specific RPC_WALLET_NOT_FOUND error instead of
RPC_INVALID_PARAMETER in case an invalid wallet was specified, for consistency.

Change wallet method disabled error text

Not strictly backwards compatible because the error is not new in this release.

Fixes T185

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10931
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1750
Build 1750: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Jan 23 2018, 21:45
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
60 ↗(On Diff #2703)

Please keep the braces.

This revision now requires changes to proceed.Jan 23 2018, 21:45

You only submited the topmost patch. You need to squash everything, or use git commit --am

deadalnix requested changes to this revision.Jan 23 2018, 23:28
This revision now requires changes to proceed.Jan 23 2018, 23:28
This revision is now accepted and ready to land.Jan 24 2018, 00:44
This revision was automatically updated to reflect the committed changes.