Page MenuHomePhabricator
Create Task
Maniphest T185

Backport Core PR10931: Fix misleading "Method not found" multiwallet errors
Closed, ResolvedPublic
Actions

Description

commit 0b11a07848754347add990a2b2cff4828ffa2be0
Merge: ba1bbb049 df389bca2
Author: Wladimir J. van der Laan <laanwj@gmail.com>
Date: Thu Jul 27 17:51:14 2017 +0200

Merge #10931: Fix misleading "Method not found" multiwallet errors

df389bc Change wallet method disabled error text (Russell Yanofsky)
e526b3d Fix misleading "Method not found" multiwallet errors (Russell Yanofsky)

Pull request description:

  Raise RPC_WALLET_NOT_SPECIFIED instead of RPC_METHOD_NOT_FOUND when a required
  wallet filename was not specified in an RPC call.

  Also raise more specific RPC_WALLET_NOT_FOUND error instead of
  RPC_INVALID_PARAMETER in case an invalid wallet was specified, for consistency.

Tree-SHA512: 6a8d885283f69bcfc28f2e08ac03eff02f9f8160a312ce2a90d868aa52533434fc0b4c4ab86547c2f09392338956df915637eaf7136a4fc105e6c8179f2d0ac8

Revisions and Commits

rABC Bitcoin ABC
D1024rABCe4f59d0d5393 Fix misleading "Method not found" multiwallet errors
rSTAGING Bitcoin ABC staging
D1024rSTAGINGe4f59d0d5393 Fix misleading "Method not found" multiwallet errors

Related Objects
Search...

Event Timeline

schancel created this task.Jan 21 2018, 05:33
schancel edited parent tasks, added: T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test; removed: T173: Backport Core PR10849: Multiwallet: simplest endpoint support.Jan 23 2018, 01:03
schancel added a subtask: T125: Backport Core PR10711: [tests] Introduce TestNode.
deadalnix removed a subtask: T125: Backport Core PR10711: [tests] Introduce TestNode.Jan 23 2018, 01:08
deadalnix added a parent task: T125: Backport Core PR10711: [tests] Introduce TestNode.
deadalnix removed a parent task: T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.Jan 23 2018, 01:13
deadalnix added a subtask: T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.
schancel edited parent tasks, added: T190: Backport Core PR10885: Reject invalid wallets; removed: T125: Backport Core PR10711: [tests] Introduce TestNode.Jan 23 2018, 01:18
schancel removed a subtask: T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.
schancel edited parent tasks, added: T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test; removed: T190: Backport Core PR10885: Reject invalid wallets.
schancel added a subtask: T125: Backport Core PR10711: [tests] Introduce TestNode.Jan 23 2018, 01:21
schancel added a subtask: T174: Backport Core PR11310: [tests] Test listwallets RPC.
schancel removed a subtask: T125: Backport Core PR10711: [tests] Introduce TestNode.Jan 23 2018, 02:04
schancel edited parent tasks, added: T125: Backport Core PR10711: [tests] Introduce TestNode; removed: T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.
schancel added a subtask: T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.
schancel removed a subtask: T174: Backport Core PR11310: [tests] Test listwallets RPC.Jan 23 2018, 02:14
matiu claimed this task.Jan 23 2018, 15:10
matiu added a revision: D1024: Fix misleading "Method not found" multiwallet errors.Jan 23 2018, 16:37
matiu closed this task as Resolved by committing rABCe4f59d0d5393: Fix misleading "Method not found" multiwallet errors.Jan 24 2018, 01:03
matiu added a commit: rABCe4f59d0d5393: Fix misleading "Method not found" multiwallet errors.
deadalnix closed subtask T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test as Resolved.Jan 25 2018, 18:07
matiu added a commit: rSTAGINGe4f59d0d5393: Fix misleading "Method not found" multiwallet errors.Mar 1 2018, 23:45