Page MenuHomePhabricator
Create Task
Maniphest T172

Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test
Closed, ResolvedPublic
Actions

Description

commit 420238d3103aa5c2e0ad29be840ba5d04b9d243e
Merge: 6adc3a373 3707fcd94
Author: Wladimir J. van der Laan <laanwj@gmail.com>
Date:   Fri Jul 21 15:34:11 2017 +0200

    Merge #10604: [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test

    3707fcd [wallet] [tests] Add listwallets to multiwallet test (John Newbery)
    9508761 [wallet] [rpc] Add listwallets RPC (John Newbery)
    4a05715 [wallet] [rpc] print wallet name in getwalletinfo (John Newbery)
    09eacee [wallet] fix comment for CWallet::Verify() (John Newbery)

    Pull request description:

      - fix comment for CWallet::Verify (cleanup after #8694)
      - expose the wallet name in `getwalletinfo` rpc
      - add `listwallets` rpc - returns array of wallet names
      - add functional test for multiwallet using new rpc functionality

    Tree-SHA512: 52f864726bf8a28421d4f3604a6cb95fffb3f4e19edbce18efaef06142c48dd4adb9e7a65a10de2955c80f13c00803ce27c78ccbc8434d92ef12cd36c4ccb4aa

Revisions and Commits

rABC Bitcoin ABC
AbandonedD1033 [backport] [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test
ClosedD988 [backport] Reject invalid wallets
D1035rABC4cc6a9dda9fb [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and…
rSTAGING Bitcoin ABC staging
D1035rSTAGING4cc6a9dda9fb [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and…

Related Objects
Search...

StatusAssignedTask
 OpenFabienT220 Backport Core PR 11492: Fix leak in CDB constructor
 ResolvedFabienT211 Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls
 OpenNoneT126 Backports from Bitcoin Core
 ResolvedNoneT184 Backport core PR11183: [tests] Add P2P interface to TestNode
 ResolvedNoneT183 Backport Core PR11067: [qa] TestNode: Add wait_until_stopped helper method
 ResolveddeadalnixT182 Backport Core PR11121: TestNode tidyups
 ResolvedmatiuT210 Backport Core P10997 and PR11125: Add bitcoin-cli -stdin and -stdinrpcpass
 ResolvedschancelT181 Backport Core PR10883 and PR 10812
 ResolveddeadalnixT180 Backport Core PR10798: [tests] [utils] test bitcoin-cli
 ResolveddeadalnixT179 Backport Core PR11077: [tests] fix timeout issues from TestNode
 ResolveddeadalnixT125 Backport Core PR10711: [tests] Introduce TestNode
 ResolvedmatiuT185 Backport Core PR10931: Fix misleading "Method not found" multiwallet errors
 OpenschancelT178 Backport Core PR12166: [docs] Clarify -walletdir usage
 ResolvedNoneT177 Backport Core PR11743: qa: Add multiwallet prefix test
 ResolvedschancelT176 Backport Core PR11472: qa: Make tmpdir option an absolute path, misc cleanup
 OpenschancelT175 Backport Core PR11277: Fix uninitialized URI in batch RPC requests
 ResolvedschancelT174 Backport Core PR11310: [tests] Test listwallets RPC
 ResolvedschancelT172 Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test
 ResolvedNoneT190 Backport Core PR10885: Reject invalid wallets
 ResolvedNoneT173 Backport Core PR10849: Multiwallet: simplest endpoint support
 ResolvedNoneT186 Backport Core PR10683: rpc: Move the `generate` RPC call to rpcwallet

Event Timeline

schancel created this task.Jan 20 2018, 20:00

This backport will depend on D987.

schancel added a parent task: T173: Backport Core PR10849: Multiwallet: simplest endpoint support.Jan 20 2018, 20:03
schancel removed a parent task: T126: Backports from Bitcoin Core.Jan 21 2018, 03:31
schancel added a subtask: T125: Backport Core PR10711: [tests] Introduce TestNode.
schancel edited parent tasks, added: T190: Backport Core PR10885: Reject invalid wallets; removed: T173: Backport Core PR10849: Multiwallet: simplest endpoint support.Jan 22 2018, 18:45
schancel added a revision: D988: [backport] Reject invalid wallets.
schancel mentioned this in rABC8a35da7fd454: [backport] Reject invalid wallets.Jan 23 2018, 00:38
schancel added a subtask: T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors.Jan 23 2018, 01:03
schancel removed a subtask: T125: Backport Core PR10711: [tests] Introduce TestNode.
deadalnix removed a subtask: T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors.Jan 23 2018, 01:13
deadalnix added a parent task: T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors.
schancel removed a parent task: T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors.Jan 23 2018, 01:19
schancel added a subtask: T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors.
schancel added a subtask: T125: Backport Core PR10711: [tests] Introduce TestNode.
schancel removed a subtask: T125: Backport Core PR10711: [tests] Introduce TestNode.
schancel removed a subtask: T174: Backport Core PR11310: [tests] Test listwallets RPC.Jan 23 2018, 01:22
schancel removed a subtask: T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors.Jan 23 2018, 02:04
schancel edited parent tasks, added: T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors; removed: T190: Backport Core PR10885: Reject invalid wallets.
schancel added a subtask: T190: Backport Core PR10885: Reject invalid wallets.
schancel added a parent task: T174: Backport Core PR11310: [tests] Test listwallets RPC.Jan 23 2018, 02:13
schancel claimed this task.Jan 24 2018, 23:48
schancel added a revision: D1033: [backport] [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.Jan 25 2018, 05:22
deadalnix added a revision: D1035: [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test..Jan 25 2018, 17:47
deadalnix closed this task as Resolved by committing rABC4cc6a9dda9fb: [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and….Jan 25 2018, 18:07
deadalnix added a commit: rABC4cc6a9dda9fb: [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and….
schancel mentioned this in rSTAGING8a35da7fd454: [backport] Reject invalid wallets.Mar 1 2018, 23:44
deadalnix added a commit: rSTAGING4cc6a9dda9fb: [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and….Mar 1 2018, 23:45
schancel renamed this task from Backport core PR 10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test to Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.Oct 26 2018, 20:16