Page MenuHomePhabricator
Create Task
Maniphest T190

Backport Core PR10885: Reject invalid wallets
Closed, ResolvedPublic
Actions

Description

Backport of Bitcoin Core PR#10885: Reject invalid wallets

d84e78e [wallet] Specify wallet name in wallet loading errors (John Newbery)
a6da027 Reject invalid wallet files (João Barbosa)
3ef77a0 Reject duplicate wallet filenames (João Barbosa)

Pull request description:

This PR prevents loading the same wallet more than once in a multi wallet scenario. It also prevents loading with invalid files: non regular files or symlinks.

Revisions and Commits

rABC Bitcoin ABC
D988rABC8a35da7fd454 [backport] Reject invalid wallets
rSTAGING Bitcoin ABC staging
D988rSTAGING8a35da7fd454 [backport] Reject invalid wallets

Related Objects
Search...

StatusAssignedTask
 OpenFabienT220 Backport Core PR 11492: Fix leak in CDB constructor
 ResolvedFabienT211 Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls
 OpenNoneT126 Backports from Bitcoin Core
 ResolvedNoneT184 Backport core PR11183: [tests] Add P2P interface to TestNode
 ResolvedNoneT183 Backport Core PR11067: [qa] TestNode: Add wait_until_stopped helper method
 ResolveddeadalnixT182 Backport Core PR11121: TestNode tidyups
 ResolvedmatiuT210 Backport Core P10997 and PR11125: Add bitcoin-cli -stdin and -stdinrpcpass
 ResolvedschancelT181 Backport Core PR10883 and PR 10812
 ResolveddeadalnixT180 Backport Core PR10798: [tests] [utils] test bitcoin-cli
 ResolveddeadalnixT179 Backport Core PR11077: [tests] fix timeout issues from TestNode
 ResolveddeadalnixT125 Backport Core PR10711: [tests] Introduce TestNode
 ResolvedmatiuT185 Backport Core PR10931: Fix misleading "Method not found" multiwallet errors
 OpenschancelT178 Backport Core PR12166: [docs] Clarify -walletdir usage
 ResolvedNoneT177 Backport Core PR11743: qa: Add multiwallet prefix test
 ResolvedschancelT176 Backport Core PR11472: qa: Make tmpdir option an absolute path, misc cleanup
 OpenschancelT175 Backport Core PR11277: Fix uninitialized URI in batch RPC requests
 ResolvedschancelT174 Backport Core PR11310: [tests] Test listwallets RPC
 ResolvedschancelT172 Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test
 ResolvedNoneT190 Backport Core PR10885: Reject invalid wallets
 ResolvedNoneT173 Backport Core PR10849: Multiwallet: simplest endpoint support
 ResolvedNoneT186 Backport Core PR10683: rpc: Move the `generate` RPC call to rpcwallet

Event Timeline

schancel created this task.Jan 22 2018, 18:44
schancel added a subtask: T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.
schancel added a revision: D988: [backport] Reject invalid wallets.
schancel closed this task as Resolved by committing rABC8a35da7fd454: [backport] Reject invalid wallets.Jan 23 2018, 00:38
schancel added a commit: rABC8a35da7fd454: [backport] Reject invalid wallets.
schancel added a subtask: T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors.Jan 23 2018, 01:18
schancel removed a subtask: T185: Backport Core PR10931: Fix misleading "Method not found" multiwallet errors.
schancel removed a subtask: T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.Jan 23 2018, 02:04
schancel edited parent tasks, added: T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test; removed: T173: Backport Core PR10849: Multiwallet: simplest endpoint support.
schancel added a subtask: T173: Backport Core PR10849: Multiwallet: simplest endpoint support.Jan 23 2018, 02:06
schancel added a commit: rSTAGING8a35da7fd454: [backport] Reject invalid wallets.Mar 1 2018, 23:44
schancel renamed this task from Backport of Bitcoin Core PR#10885: Reject invalid wallets to Backport of Bitcoin Core PR10885: Reject invalid wallets.Oct 26 2018, 20:16
schancel renamed this task from Backport of Bitcoin Core PR10885: Reject invalid wallets to Backport Core PR10885: Reject invalid wallets.