Page MenuHomePhabricator

Backport Core PR10883 and PR 10812
Closed, ResolvedPublic

Description

commit bf3b742e2852260f7e388ed3b9a5314351b7e31f
Merge: df0793f32 2264236da
Author: Wladimir J. van der Laan <laanwj@gmail.com>
Date: Thu Jul 20 10:29:31 2017 +0200

Merge #10883: Rename -usewallet to -rpcwallet

2264236 Rename -usewallet to -rpcwallet (Alex Morcos)

Pull request description:

Tree-SHA512: 99bdbff5d18e464e620b7b2a1ff8db874b3888db4d43348c96c372097ed51edd796b564e4ef1193ccd75d0a1fd51f865cf6fff4e0e3672654cd2933c851d210a

and....

Author: Pieter Wuille <pieter.wuille@gmail.com>
Date: Sat Jul 15 13:16:56 2017 -0700

Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets

5c643241e [utils] allow square brackets for ipv6 addresses in bitcoin-cli (John Newbery)
fe4fabaf1 [refactor] move SplitHostPort() into utilstrencodings (John Newbery)

Pull request description:

  bitcoin-cli's `-rpcconnect` can accept ipv6 addresses (as long as the libevent version is new enough), but fails to parse ipv6 with square brackets. This PR makes `bitcoin-cli` parse ipv6 in square brackets correctly.

  `bitcoin-cli -rpcconnect=[::1] <command>`

  should now be equivalent to

  `bitcoin-cli -rpcconnect=::1 <command>`

  This is useful so the `bitcoin-cli` option can now be in the same format as the `bitcoind` option.

  Doesn't include tests. I have a branch that fully tests `bitcoin-cli`, but that's queued behind several intermediate PRs.

  - first commit moves `SplitHostPort()` from libbitcoin_common into libbitcoin_util
  - second commit adds proper ipv6 parsing to bitcoin-cli

Tree-SHA512: 249d409f10360c989474283341f458cc97364a56a7d004ae6d5f13d8bffe3a51b5dc2484d42218848e2d42cd9c0b13a1b92e94ea19b209f7e91c875c208d8409

Event Timeline

schancel created this task.Jan 21 2018, 03:55
schancel renamed this task from Backport Core PR10997: RPC: Add option -stdinrpcpass to bitcoin-cli to allow RPC password to be read from standard input to Backport Core PR10997 and PR10883.Jan 30 2018, 06:16
schancel updated the task description. (Show Details)
schancel renamed this task from Backport Core PR10997 and PR10883 to Backport Core PR10997 and PR10883 and PR 10812.Jan 30 2018, 06:29
schancel updated the task description. (Show Details)
schancel claimed this task.Jan 30 2018, 13:12

Currently working on this.

schancel renamed this task from Backport Core PR10997 and PR10883 and PR 10812 to Backport Core PR10883 and PR 10812.Jan 30 2018, 19:08
schancel updated the task description. (Show Details)