Details

Reviewers

deadalnix
matiu

Group Reviewers

Restricted Project

Maniphest Tasks

T181: Backport Core PR10883 and PR 10812

Commits

rSTAGING3982657ab67a: Rename usewallet to rpcwallet, and allow square brackets for ipv6 addresses
rABC3982657ab67a: Rename usewallet to rpcwallet, and allow square brackets for ipv6 addresses

Summary

Backport Core PR10883 and PR10812

2264236   Rename -usewallet to -rpcwallet
5c643241e [refactor] move SplitHostPort() into utilstrencodings
fe4fabaf1 [utils] allow square brackets for ipv6 addresses in bitcoin-cli

Closes T181

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

schancel created this revision.Jan 30 2018, 19:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2018, 19:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel retitled this revision from [backport] Prepare to add `-stdinrpcpass` to [backport] Allow square brackets for ipv6 addresses in bitcoin-cli.Jan 30 2018, 19:49

jasonbcox added a subscriber: jasonbcox.Jan 30 2018, 21:30

jasonbcox added inline comments.

src/utilstrencodings.cpp
106–109 ↗	(On Diff #2757)	This if-statement should have curly brackets

Accepting, but you do what @jasonbcox 's is suggesting.

This revision is now accepted and ready to land.Jan 30 2018, 21:47

schancel added inline comments.Jan 30 2018, 23:24

src/utilstrencodings.cpp
106–109 ↗	(On Diff #2757)	Thanks for the catch. I should have looked this code over more closely.

schancel retitled this revision from [backport] Allow square brackets for ipv6 addresses in bitcoin-cli to Allow square brackets for ipv6 addresses in bitcoin-cli.Jan 31 2018, 19:12

Fix curlies

schancel retitled this revision from Allow square brackets for ipv6 addresses in bitcoin-cli to Rename usewallet to rpcwallet, and allow square brackets for ipv6 addresses.Jan 31 2018, 21:14

Rebase

Harbormaster completed remote builds in B1788: Diff 2784.Jan 31 2018, 21:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.