Page MenuHomePhabricator

Rename usewallet to rpcwallet, and allow square brackets for ipv6 addresses
ClosedPublic

Authored by schancel on Jan 30 2018, 19:14.

Details

Summary

Backport Core PR10883 and PR10812

2264236   Rename -usewallet to -rpcwallet
5c643241e [refactor] move SplitHostPort() into utilstrencodings
fe4fabaf1 [utils] allow square brackets for ipv6 addresses in bitcoin-cli

Closes T181

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
stdinrpcpass
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1771
Build 1771: arc lint + arc unit

Event Timeline

schancel retitled this revision from [backport] Prepare to add `-stdinrpcpass` to [backport] Allow square brackets for ipv6 addresses in bitcoin-cli.Jan 30 2018, 19:49
jasonbcox added inline comments.
src/utilstrencodings.cpp
106–109

This if-statement should have curly brackets

Accepting, but you do what @jasonbcox 's is suggesting.

This revision is now accepted and ready to land.Jan 30 2018, 21:47
src/utilstrencodings.cpp
106–109

Thanks for the catch. I should have looked this code over more closely.

schancel retitled this revision from [backport] Allow square brackets for ipv6 addresses in bitcoin-cli to Allow square brackets for ipv6 addresses in bitcoin-cli.Jan 31 2018, 19:12
schancel retitled this revision from Allow square brackets for ipv6 addresses in bitcoin-cli to Rename usewallet to rpcwallet, and allow square brackets for ipv6 addresses.Jan 31 2018, 21:14

Remove gArgs wrapper calls.