Page MenuHomePhabricator

Backport Core PR11472: qa: Make tmpdir option an absolute path, misc cleanup
Closed, ResolvedPublic

Description

commit 6759a24eaaf72019255854cf9e7ff2b462e4f978
Merge: 50d72b357 fafa00397
Author: Wladimir J. van der Laan <laanwj@gmail.com>
Date: Wed Oct 18 16:52:44 2017 +0200

Merge #11472: qa: Make tmpdir option an absolute path, misc cleanup

fafa003 qa: Remove never used return value of sync_with_ping (MarcoFalke)
fa9de37 qa: Make tmpdir option an absolute path (MarcoFalke)

Pull request description:

  This should fix issues with the multiwallet test and its symlinks
  when the tmpdir is a relative path.

  Rather than fixing os.symlink to work with paths relative to a
  directory descriptor, which does not work on Windows, normalize
  the path instead.

Tree-SHA512: 189690f3d065ea2f0f48e06775c86d513d0916c7c86312432e8e16df160e65539e288c2bd53d49a4180735fa940f6fcd52b506ccd7d9815651a9b1a69850dda6

Event Timeline

schancel created this task.Jan 21 2018, 03:32
schancel renamed this task from Backpor Core PR11472: qa: Make tmpdir option an absolute path, misc cleanup to Backport Core PR11472: qa: Make tmpdir option an absolute path, misc cleanup.Jan 21 2018, 03:43
VohaVo added a subscriber: VohaVo.Feb 21 2018, 05:01
schancel claimed this task.Oct 17 2018, 21:14
jasonbcox closed this task as Resolved.Oct 26 2018, 20:15
jasonbcox added a subscriber: jasonbcox.

This change is already done.