Page MenuHomePhabricator

[backport] Multiwallet: simplest endpoint support
ClosedPublic

Authored by schancel on Jan 20 2018, 06:19.

Details

Summary

Backport of Core PR #10849: Multiwallet: simplest endpoint support

6b9faf7 [QA] add basic multiwallet test (Jonas Schnelli)
979d0b8 [tests] [wallet] Add wallet endpoint support to authproxy (John Newbery)
76603b1 Select wallet based on the given endpoint (Jonas Schnelli)
32c9710 Fix test_bitcoin circular dependency issue (Jonas Schnelli)
31e0720 Add wallet endpoint support to bitcoin-cli (-usewallet) (Jonas Schnelli)
dd2185c Register wallet endpoint (Jonas Schnelli)

Depends on D985, and D1003
Closes T173

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Jan 20 2018, 06:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2018, 06:19
schancel edited the summary of this revision. (Show Details)Jan 20 2018, 06:28
deadalnix requested changes to this revision.Jan 21 2018, 00:20
deadalnix added inline comments.
src/httpserver.cpp
664 ↗(On Diff #2601)

nullptr

test/functional/multiwallet.py
1 ↗(On Diff #2601)

Where does this file come from ? It is supposed to be created in that PR. Also, where is the change in the testrunner ?

This revision now requires changes to proceed.Jan 21 2018, 00:20
schancel updated this revision to Diff 2627.Jan 21 2018, 02:21

Rebase?

schancel updated this revision to Diff 2629.Jan 21 2018, 02:55

Fix nullptr

schancel updated this revision to Diff 2636.Jan 21 2018, 09:13

Rebase onto D1003

schancel updated this revision to Diff 2647.Jan 21 2018, 19:42

Rebase w/ memory header

deadalnix accepted this revision.Jan 22 2018, 16:18
This revision is now accepted and ready to land.Jan 22 2018, 16:18
This revision was automatically updated to reflect the committed changes.