Page MenuHomePhabricator

[backport] Multiwallet: simplest endpoint support
ClosedPublic

Authored by schancel on Jan 20 2018, 06:19.

Details

Reviewers
deadalnix
jasonbcox
matiu
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Restricted Maniphest Task
Commits
rSTAGING91175ae4bbd2: [backport] Multiwallet: simplest endpoint support
rABC91175ae4bbd2: [backport] Multiwallet: simplest endpoint support
Summary

Backport of Core PR #10849: Multiwallet: simplest endpoint support

6b9faf7 [QA] add basic multiwallet test (Jonas Schnelli)
979d0b8 [tests] [wallet] Add wallet endpoint support to authproxy (John Newbery)
76603b1 Select wallet based on the given endpoint (Jonas Schnelli)
32c9710 Fix test_bitcoin circular dependency issue (Jonas Schnelli)
31e0720 Add wallet endpoint support to bitcoin-cli (-usewallet) (Jonas Schnelli)
dd2185c Register wallet endpoint (Jonas Schnelli)

Depends on D985, and D1003
Closes T173

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
depends-on-D985
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1715
Build 1715: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Jan 21 2018, 00:20
deadalnix added inline comments.
src/httpserver.cpp
664 ↗(On Diff #2601)

nullptr

test/functional/multiwallet.py
1 ↗(On Diff #2601)

Where does this file come from ? It is supposed to be created in that PR. Also, where is the change in the testrunner ?

This revision now requires changes to proceed.Jan 21 2018, 00:20
schancel added a task: Restricted Maniphest Task.
This revision is now accepted and ready to land.Jan 22 2018, 16:18
schancel added a task: Restricted Maniphest Task.
This revision was automatically updated to reflect the committed changes.