Page MenuHomePhabricator

[backport] [wallet] [tests] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test
AbandonedPublic

Authored by schancel on Jan 25 2018, 05:22.

Details

Summary

Backport Core PR10604: [wallet] [tests] Add listwallets RPC, include wallet name in getwalletinfo and add multiwallet test

3707fcd [wallet] [tests] Add listwallets to multiwallet test (John Newbery)
9508761 [wallet] [rpc] Add listwallets RPC (John Newbery)
4a05715 [wallet] [rpc] print wallet name in getwalletinfo (John Newbery)
09eacee [wallet] fix comment for CWallet::Verify() (John Newbery)

Pull request description:

  - fix comment for CWallet::Verify (cleanup after #8694)
  - expose the wallet name in `getwalletinfo` rpc
  - add `listwallets` rpc - returns array of wallet names
  - add functional test for multiwallet using new rpc functionality

Depends on D1032
Closes T172

Test Plan

make check && ./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10604
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1756
Build 1756: arc lint + arc unit

Event Timeline

schancel created this revision.Jan 25 2018, 05:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2018, 05:22
matiu requested changes to this revision.Jan 25 2018, 16:10

Added to minor comments.

test/functional/multiwallet.py
60
  1. check w2 wallet balance
71

Isn't this checked already in l58/65/69?

This revision now requires changes to proceed.Jan 25 2018, 16:10
schancel added inline comments.Jan 27 2018, 23:06
test/functional/multiwallet.py
71

Good catch. I think i'm missing a call to listwallets somewhere.

schancel abandoned this revision.Jan 27 2018, 23:10

D1035 already landed