Differential D10383

[avalanche] Remove the invalid peers before the orphans rescan
ClosedPublic
Actions

Authored by Fabien on Oct 22 2021, 08:31.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCf380d4e818a0: [avalanche] Remove the invalid peers before the orphans rescan

Summary

This makes it possible to pull back proofs with utxos that conflicted with these invalid peers.

Ref T1854.

Depends on D10370.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_remove_invalid_peers_before_rescan

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17104
Build 34040: Build Diff	build-debug · build-without-wallet · lint-circular-dependencies · build-diff · build-clang-tidy · build-clang
Build 34039: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 22 2021, 08:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2021, 08:32

Fabien requested review of this revision.Oct 22 2021, 08:32

Fabien mentioned this in D10377: [avalanche] Orphan the conflicting proofs rather than ignoring them.Oct 22 2021, 08:40

Fabien added a child revision: D10377: [avalanche] Orphan the conflicting proofs rather than ignoring them.Oct 22 2021, 08:41

Harbormaster completed remote builds in B17104: Diff 30645.Oct 22 2021, 08:46

deadalnix accepted this revision.Oct 26 2021, 00:14

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/avalanche/test/peermanager_tests.cpp
820	Maybe pb.build should a return a ProofRef?

This revision is now accepted and ready to land.Oct 26 2021, 00:14

Fabien added inline comments.Oct 26 2021, 07:13

src/avalanche/test/peermanager_tests.cpp
820	yes

Closed by commit rABCf380d4e818a0: [avalanche] Remove the invalid peers before the orphans rescan (authored by Fabien). · Explain WhyOct 26 2021, 07:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf380d4e818a0: [avalanche] Remove the invalid peers before the orphans rescan.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

11 lines

test/

peermanager_tests.cpp

69 lines

Diff 30645

View Options

src/avalanche/peermanager.cpp