Page MenuHomePhabricator
Differential D10410

[Cashtab]edited readme copy
ClosedPublic
Actions

Authored by kieran709 on Nov 1 2021, 13:59.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC41bcc04c3ea9: [Cashtab]edited readme copy
Summary

updated readme to include references to XEC and eCash, related to task T1934

Test Plan

navigate to readme, ensure copy does not contain mistakes .

Diff Detail

Repository
rABC Bitcoin ABC
Branch
update-cashtab-readme
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17154
Build 34139: Build Diffcashtab-tests
Build 34138: arc lint + arc unit

Event Timeline

kieran709 created this revision.Nov 1 2021, 13:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2021, 13:59
kieran709 requested review of this revision.Nov 1 2021, 13:59
Harbormaster completed remote builds in B17153: Diff 30720.Nov 1 2021, 14:02
kieran709 updated this revision to Diff 30721.Nov 1 2021, 14:34

added screenshot to readme

Harbormaster completed remote builds in B17154: Diff 30721.Nov 1 2021, 14:37
bytesofman requested changes to this revision.Nov 1 2021, 22:54
bytesofman added inline comments.
web/cashtab/src/components/Configure/Configure.js
530

Remove

This revision now requires changes to proceed.Nov 1 2021, 22:54
kieran709 updated this revision to Diff 30748.Nov 2 2021, 16:37

responding to review feedback, removed uneccessary console.log

Harbormaster completed remote builds in B17176: Diff 30748.Nov 2 2021, 16:44
bytesofman accepted this revision.Nov 4 2021, 19:10
This revision is now accepted and ready to land.Nov 4 2021, 19:10
Closed by commit rABC41bcc04c3ea9: [Cashtab]edited readme copy (authored by kieran709). · Explain WhyNov 4 2021, 20:52
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC41bcc04c3ea9: [Cashtab]edited readme copy.

Revision Contents
Changeset List

PathSize
web/
cashtab/
10 lines
screenshots/
src/
components/
Configure/
1 line

Diff 30721

View Options

web/cashtab/README.md

Loading...
View Options

web/cashtab/screenshots/ss-readme.png

Loading...
View Options

web/cashtab/src/components/Configure/Configure.js

Loading...