Page MenuHomePhabricator

Lock before checking if orphan_work_set is empty; indicate it is guarded
ClosedPublic

Authored by PiRK on Wed, Nov 24, 17:13.

Details

Summary
Test Plan
cmake .. -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug -DENABLE_SANITIZERS=thread
ninja && ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Wed, Nov 24, 17:14
This revision is now accepted and ready to land.Thu, Nov 25, 10:53
Fabien requested changes to this revision.Thu, Nov 25, 10:53

Please update the test plan (and run the tests) to challenge the locks

This revision now requires changes to proceed.Thu, Nov 25, 10:53

run thread sanitizer as test plan

This revision is now accepted and ready to land.Thu, Nov 25, 15:09