Differential D10528

Lock before checking if orphan_work_set is empty; indicate it is guarded
ClosedPublic
Actions

Authored by PiRK on Nov 24 2021, 17:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC68ee81260cd8: Lock before checking if orphan_work_set is empty; indicate it is guarded

Summary

This is a backport of core#19911 [3/6]
https://github.com/bitcoin/bitcoin/pull/19911/commits/673247b58cd1252ab7e99f7d63ead05cc100cef2

Depends on D10527

Test Plan

cmake .. -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug -DENABLE_SANITIZERS=thread
ninja && ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 24 2021, 17:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2021, 17:13

PiRK requested review of this revision.Nov 24 2021, 17:14

teamcity edited the summary of this revision. (Show Details)Nov 24 2021, 17:14

PiRK added a child revision: D10529: Move vRecvGetData to net processing.Nov 24 2021, 17:14

Harbormaster completed remote builds in B17341: Diff 30993.Nov 24 2021, 17:37

Fabien accepted this revision.Nov 25 2021, 10:53

This revision is now accepted and ready to land.Nov 25 2021, 10:53

Please update the test plan (and run the tests) to challenge the locks

This revision now requires changes to proceed.Nov 25 2021, 10:53

Fabien mentioned this in D10530: Guard vRecvGetData (now in net processing) with its own mutex.Nov 25 2021, 11:04

run thread sanitizer as test plan

@bot build-tsan

teamcity awarded a token.Nov 25 2021, 12:59

PiRK edited the test plan for this revision. (Show Details)Nov 25 2021, 13:04

Harbormaster completed remote builds in B17363: Diff 31022.Nov 25 2021, 13:17

Fabien accepted this revision.Nov 25 2021, 15:09

This revision is now accepted and ready to land.Nov 25 2021, 15:09

Closed by commit rABC68ee81260cd8: Lock before checking if orphan_work_set is empty; indicate it is guarded (authored by Neha Narula <narula@gmail.com>, committed by PiRK). · Explain WhyNov 25 2021, 15:27

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC68ee81260cd8: Lock before checking if orphan_work_set is empty; indicate it is guarded.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

15 lines

Diff 31032

View Options

Lock before checking if orphan_work_set is empty; indicate it is guardedClosedPublicActions