Guard vRecvGetData (now in net processing) with its own mutex
ClosedPublic
Actions

Authored by PiRK on Nov 24 2021, 17:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC95cde14da7a6: Guard vRecvGetData (now in net processing) with its own mutex

Summary

This requires slightly reorganizing the logic in GETBLOCKTXN to
maintain locking order.

This is a backport of core#19911 [5/6]
https://github.com/bitcoin/bitcoin/pull/19911/commits/ba951812ec0cc8ebee5911a582f188525b76ff0a

see D10187 for the removal of the !cs_main negative lock

Depends on D10529

Test Plan

cmake .. -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug -DENABLE_SANITIZERS=thread
ninja && ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 24 2021, 17:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2021, 17:19

PiRK requested review of this revision.Nov 24 2021, 17:19

teamcity edited the summary of this revision. (Show Details)Nov 24 2021, 17:19

PiRK added a child revision: D10531: scripted-diff: rename vRecvGetData.Nov 24 2021, 17:39

Harbormaster completed remote builds in B17343: Diff 30995.Nov 24 2021, 17:47

Same as D10528, the test plan doesn't test for the changes

This revision now requires changes to proceed.Nov 25 2021, 11:04

@bot build-tsan

teamcity awarded a token.Nov 25 2021, 13:07

Fabien accepted this revision.Nov 25 2021, 15:14

This revision is now accepted and ready to land.Nov 25 2021, 15:14

Closed by commit rABC95cde14da7a6: Guard vRecvGetData (now in net processing) with its own mutex (authored by Neha Narula <narula@gmail.com>, committed by PiRK). · Explain WhyNov 25 2021, 15:29

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC95cde14da7a6: Guard vRecvGetData (now in net processing) with its own mutex.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

126 lines

Diff 31035

View Options

Guard vRecvGetData (now in net processing) with its own mutexClosedPublicActions