Page MenuHomePhabricator
Differential D10586

[avalanche] Add a ProofPool getProof accessor to retrieve a proof from its id
ClosedPublic
Actions

Authored by Fabien on Nov 29 2021, 13:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCd5ef60bbc209: [avalanche] Add a ProofPool getProof accessor to retrieve a proof from its id
Summary

This will be used several times in the code, so wrap it into an accessor.

Ref T1854.

Depends on D10522.

Test Plan
ninja all check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_proofpool_getproof
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17436
Build 34700: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 34699: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 29 2021, 13:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2021, 13:18
Fabien requested review of this revision.Nov 29 2021, 13:18
Fabien added a child revision: D10523: [avalanche] Use the ProofPool multi index to store the orphan proofs.Nov 29 2021, 13:23
Harbormaster completed remote builds in B17436: Diff 31137.Nov 29 2021, 14:06
deadalnix accepted this revision.Nov 29 2021, 22:10
This revision is now accepted and ready to land.Nov 29 2021, 22:10
Fabien added a child revision: D10597: [avalanche] Make the proof pool internal container private.Nov 30 2021, 10:24
Fabien removed a child revision: D10523: [avalanche] Use the ProofPool multi index to store the orphan proofs.Nov 30 2021, 10:47
Closed by commit rABCd5ef60bbc209: [avalanche] Add a ProofPool getProof accessor to retrieve a proof from its id (authored by Fabien). · Explain WhyNov 30 2021, 19:12
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd5ef60bbc209: [avalanche] Add a ProofPool getProof accessor to retrieve a proof from its id.
Fabien removed a child revision: D10597: [avalanche] Make the proof pool internal container private.Nov 30 2021, 19:47

Revision Contents
Changeset List

PathSize
src/
avalanche/
2 lines
6 lines
test/
18 lines

Diff 31137

View Options

src/avalanche/proofpool.h

Loading...
View Options

src/avalanche/proofpool.cpp

Loading...
View Options

src/avalanche/test/proofpool_tests.cpp

Loading...