Page MenuHomePhabricator

[avalanche] Improve the peer manager verify() method
ClosedPublic

Authored by Fabien on Dec 1 2021, 14:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC7ce8011a6c7b: [avalanche] Improve the peer manager verify() method
Summary

Use identity comparison when checking the peers and proof pool consistency, and add comments for what the comparisons are for. Not only the proof ids must match, but they are expected to be the same underlying pointer.

Ref T1854.

Test Plan
ninja all check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_peermanager_verify_proof_identity
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17489
Build 34804: Build Diffbuild-without-wallet · build-clang-tidy · lint-circular-dependencies · build-clang · build-diff · build-debug
Build 34803: arc lint + arc unit