Differential D10603

[avalanche] Improve the peer manager verify() method
ClosedPublic
Actions

Authored by Fabien on Dec 1 2021, 14:54.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC7ce8011a6c7b: [avalanche] Improve the peer manager verify() method

Summary

Use identity comparison when checking the peers and proof pool consistency, and add comments for what the comparisons are for. Not only the proof ids must match, but they are expected to be the same underlying pointer.

Ref T1854.

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 1 2021, 14:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2021, 14:54

Fabien requested review of this revision.Dec 1 2021, 14:54

Fabien mentioned this in D10597: [avalanche] Make the proof pool internal container private.Dec 1 2021, 15:00

Fabien added a child revision: D10597: [avalanche] Make the proof pool internal container private.Dec 1 2021, 15:01

Harbormaster completed remote builds in B17489: Diff 31207.Dec 1 2021, 15:08

deadalnix accepted this revision.Dec 1 2021, 15:21

This revision is now accepted and ready to land.Dec 1 2021, 15:21

Closed by commit rABC7ce8011a6c7b: [avalanche] Improve the peer manager verify() method (authored by Fabien). · Explain WhyDec 1 2021, 15:25

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7ce8011a6c7b: [avalanche] Improve the peer manager verify() method.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

5 lines

Diff 31216

View Options

src/avalanche/peermanager.cpp

[avalanche] Improve the peer manager verify() methodClosedPublicActions