Page MenuHomePhabricator

[wallet] fix zapwallettxes interaction with persistent mempool
ClosedPublic

Authored by deadalnix on Feb 2 2018, 21:38.

Details

Summary

Backport Core PR10330: [wallet] fix zapwallettxes interaction with persistent mempool

4c3b538 [logs] fix zapwallettxes startup logs (John Newbery)
e7a2181 [wallet] fix zapwallettxes interaction with persistent mempool (John Newbery)
ff7365e [tests] fix flake8 warnings in zapwallettxes.py (John Newbery)

Pull request description:

zapwallettxes previously did not interact well with persistent mempool.
zapwallettxes would cause wallet transactions to be zapped, but they
would then be reloaded from the mempool on startup. This commit softsets
persistmempool to false if zapwallettxes is enabled so transactions are
actually zapped.
Test Plan
make check
./test/functional/test_runner.py zapwallettxes

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 3 2018, 00:38
This revision was automatically updated to reflect the committed changes.