Page MenuHomePhabricator
Differential D1063

The young person's guide to the test_framework
ClosedPublic
Actions

Authored by schancel on Feb 3 2018, 13:30.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa35159767e07: The young person's guide to the test_framework
rABCa35159767e07: The young person's guide to the test_framework
Summary

Backport core's PR10612 and PR11025

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Feb 3 2018, 13:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2018, 13:30
Harbormaster completed remote builds in B1800: Diff 2807.Feb 3 2018, 13:30
teamcity added a subscriber: teamcity.Feb 3 2018, 13:31

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 3 2018, 13:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix added a child revision: D1065: qa: Move wait_until to util.Feb 3 2018, 17:51
schancel accepted this revision.Feb 3 2018, 22:24
schancel added a subscriber: schancel.
schancel added inline comments.
test/README.md
36 ↗(On Diff #2807)

Should replace with an example that applies to us.

This revision is now accepted and ready to land.Feb 3 2018, 22:24
jasonbcox requested changes to this revision.Feb 4 2018, 01:11
jasonbcox added a subscriber: jasonbcox.

Very useful! Thanks for writing all of this up.

test/README.md
51 ↗(On Diff #2807)

How is this different from "all possible tests" below?

This revision now requires changes to proceed.Feb 4 2018, 01:11
schancel updated this revision to Diff 2818.Feb 7 2018, 19:33

Rebase

Harbormaster failed remote builds in B1808: Diff 2818!Feb 7 2018, 19:33
teamcity added a comment.Feb 7 2018, 19:35

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B1808: Diff 2818!Feb 7 2018, 19:49
teamcity added a comment.Feb 7 2018, 19:51

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

jasonbcox accepted this revision.Feb 7 2018, 19:52
This revision is now accepted and ready to land.Feb 7 2018, 19:52
teamcity added a comment.Feb 7 2018, 19:53

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Feb 7 2018, 19:54

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 7 2018, 20:09

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Feb 7 2018, 20:12

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1808: Diff 2818.Feb 7 2018, 20:12
schancel commandeered this revision.Feb 7 2018, 20:25
schancel edited reviewers, added: deadalnix; removed: schancel.
Closed by commit rABCa35159767e07: The young person's guide to the test_framework (authored by John Newbery <john@johnnewbery.com>, committed by schancel). · Explain WhyFeb 7 2018, 20:25
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
163 lines
functional/
174 lines
231 lines

Diff 2820

View Options

test/README.md

Loading...
View Options

test/functional/README.md

Loading...
View Options

test/functional/example_test.py

Loading...