Differential D10803

Remove the deprecated banscore field from the getpeerinfo RPC
ClosedPublic
Actions

Authored by Fabien on Jan 10 2022, 14:14.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCb85e9a5f2b51: Remove the deprecated banscore field from the getpeerinfo RPC

Summary

This is a follow up to D10802. This has been deprecated for long enough.

Depends on D10802.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove_getpeerinfo_banscore

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17859
Build 35544: Build Diff	lint-circular-dependencies · build-debug · build-without-wallet · build-clang-tidy · build-diff · build-clang
Build 35543: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 10 2022, 14:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2022, 14:14

Fabien requested review of this revision.Jan 10 2022, 14:14

Harbormaster completed remote builds in B17859: Diff 31728.Jan 10 2022, 14:15

Looks good. I checked against https://github.com/bitcoin/bitcoin/pull/20755/commits/094c3beaa47c909070607e94f2544ed1472ddb17 .

This revision is now accepted and ready to land.Jan 10 2022, 14:46

Closed by commit rABCb85e9a5f2b51: Remove the deprecated banscore field from the getpeerinfo RPC (authored by Fabien). · Explain WhyJan 10 2022, 16:46

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb85e9a5f2b51: Remove the deprecated banscore field from the getpeerinfo RPC.

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

3 lines

src/

net_processing.h

1 line

net_processing.cpp

9 lines

rpc/

net.cpp

8 lines

test/

functional/

rpc_deprecated.py

5 lines

Diff 31728

View Options

doc/release-notes.md

View Options

src/net_processing.h

View Options

src/net_processing.cpp

View Options

src/rpc/net.cpp

View Options

test/functional/rpc_deprecated.py

Remove the deprecated banscore field from the getpeerinfo RPCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31728

doc/release-notes.md

src/net_processing.h

src/net_processing.cpp

src/rpc/net.cpp

test/functional/rpc_deprecated.py

Remove the deprecated banscore field from the getpeerinfo RPC
ClosedPublic
Actions

Revision Contents
Changeset List