Page MenuHomePhabricator
Differential D1083

Add support for building Qt locales with cmake
ClosedPublic
Actions

Authored by deadalnix on Feb 11 2018, 22:46.

Details

Reviewers
jasonbcox
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING927067de4ae0: Add support for building Qt locales with cmake
rABC927067de4ae0: Add support for building Qt locales with cmake
Summary

This is a first step toward being able to build bitcoin-qt with cmake.

Test Plan
ninja bitcoin-qt-base

Diff Detail

Repository
rABC Bitcoin ABC
Branch
qtlocale
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1831
Build 1853: Bitcoin ABC Buildbot (legacy)
Build 1852: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 11 2018, 22:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 11 2018, 22:46
teamcity added a subscriber: teamcity.Feb 11 2018, 22:46

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 11 2018, 23:05

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1831: Diff 2847.Feb 11 2018, 23:05
deadalnix updated this revision to Diff 2850.Feb 11 2018, 23:43

Add the qm files

teamcity added a comment.Feb 11 2018, 23:45

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 12 2018, 00:04

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1834: Diff 2850.Feb 12 2018, 00:04
jasonbcox requested changes to this revision.Feb 12 2018, 06:55
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/CMakeLists.txt
10 ↗(On Diff #2850)

Please update the title of this diff to include a note about Qt, so that it's clear from looking at git history that this change adds bitcoin-qt to the cmake build.

This revision now requires changes to proceed.Feb 12 2018, 06:55
deadalnix requested review of this revision.Feb 12 2018, 18:46
deadalnix retitled this revision from Add support for building locales with cmake to Add support for building Qt locales with cmake.

Update title.

schancel accepted this revision.Feb 12 2018, 19:28
jasonbcox accepted this revision.Feb 12 2018, 19:30
This revision is now accepted and ready to land.Feb 12 2018, 19:30
Closed by commit rABC927067de4ae0: Add support for building Qt locales with cmake (authored by deadalnix). · Explain WhyFeb 12 2018, 19:53
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
6 lines
qt/
34 lines
locale/
96 lines

Diff 2847

View Options

src/CMakeLists.txt

Loading...
View Options

src/qt/CMakeLists.txt

Loading...
View Options

src/qt/locale/CMakeLists.txt

Loading...