Tapping a tx in tx history extends a collapse which reveals: a link to the tx that opens the block explorer in a new tab and a copy txid button which fires a notification when the txid has been copied to the user's clipboard. Related to tast T1774.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
cd web/cashtab
npm start
on the main wallet tab, click on a transaction
onClick, the tx card should expand, revealing a link to the tx on the block explorer>
click on the link, it should open the block explorer in a new tab
click on the Copy Txid button, it should fire a success notification
paste the txid somewhere to ensure it was copied to the clipboard.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- tx-history-dropdown
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 18205 Build 36218: Build Diff cashtab-tests Build 36217: arc lint + arc unit
Event Timeline
Comment Actions
Great functionality. Would like to see different styling.
- Each msg should appear on the same row
- The expanded panel should obviously be part of the above transaction, i.e. in the same box
Comment Actions
Responding to review feedback, moved the collapse component out of TxHistory and into the Tx component. Moved pertinent styling out of the TxWrapper div and into the AntdCollapse Wrapper. Removed TxLink from TxHistory as it is no longer necessary and interferes with the collapse.
Comment Actions
Looking good!
- Replace "View on block explorer" text with icon of external link
- Replace "Copy txid" button with icon of copy paste
Comment Actions
responding to review feedback, renamed button component so I could reuse it to have style consistency.
Comment Actions
Good approach -- this specific diff will probably be abandoned as the new tx history components are distinct.